Heapster: Avoid shift/reduce conflicts involving bitvector negation #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now ensure that `-` has higher precedence than any other operator using `happy`'s `%left` pragma. This ensures that `- 42 + 27` parses as `(- 42) + 27`, not `- (42 + 27)` like before. While I was in town, I added `%expect 0` at the top of the parser to ensure that `happy` will error out in the future if additional shift/reduce conflicts are introduced. Fixes #1794.
RyanGlScott
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now ensure that
-has higher precedence than any other operator usinghappy's%leftpragma. This ensures that- 42 + 27parses as(- 42) + 27, not- (42 + 27)like before.While I was in town, I added
%expect 0at the top of the parser to ensure thathappywill error out in the future if additional shift/reduce conflicts are introduced.Fixes #1794.