Add bitvector fallbacks to more nat ops in the simulator #1708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the primitives for
subNat
,equalNat
, andltNat
convert their arguments to bitvectors and perform the corresponding bitvector operation if their arguments are not both concreteNatural
s.This PR adds similar bitvector fallbacks to all the remaining natural number operations except
expNat
(because there is no corresponding bitvector exp function at the moment) andnatCase
. To do this we generalize the behavior ofsubNat
,equalNat
, andltNat
into the functionsbinNatOp
andbinNatToNatOp
.Fixes #1558