Term utilities #1698
Merged
Term utilities #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chameco
approved these changes
Jul 6, 2022
| applyTypedTerm sc (TypedTerm _tp t1) (TypedTerm _ t2) = | ||
| do trm <- scApply sc t1 t2 | ||
| ty <- scTypeCheckError sc trm | ||
| ct <- scCryptolType sc ty |
There was a problem hiding this comment.
IIRC scCryptolType can be a bit weird sometimes due to the lack of an injective mapping from Cryptol types to SAWCore types. I think this might present some unintuitive behavior when (e.g.) the Term applied is a Cryptol function returning a tuple or record. I don't think this is a blocker, but it might be worth mentioning in the docs for term_apply or even just as a comment here.
and automatically builds the statement of an equality congruence lemma for that function. The generated statement can then be passed to `prove_extcore` to get a congruence lemma that can be used in proofs.
we can now construct integer and natural number terms directly from SAWCore `Int` values, or `TCNum` values from Cryptol sizes. In addition, there is now a `term_apply` operation which will construct application terms.
This can be used to prove lemmas regarding the one-step unrolling of Cryptol definitions. Also, prove an "inverse eta rule", which is really just states that applying equal functions to an argument yields equal results.
robdockins
force-pushed
the
rwd/congruence
branch
from
6d93ec7 to
8e6eb32
Compare
robdockins
added
PR: ready to merge
robdockins
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some utilities for constructing SAWCore terms.
The
term_applyprimitive gives a way to combine terms by application, which was missing previously. Thecongruence_foris a convenience that tries to automatically build the statement of a congruence lemma for a term. This statement can then be proved and applied as a lemma.