-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heapster multi-way or eliminations #1690
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ti-way eliminator for Eithers
… of eliminators, which should hopefully be better for automation...
… the Coq automation
… permissions, rather than just the top one
Whoops, looks like the mbox proofs do not work with this change yet... |
m-yac
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
m-yac
added
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
subsystem: heapster
Issues specifically related to memory verification using Heapster
labels
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
subsystem: heapster
Issues specifically related to memory verification using Heapster
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes Heapster's or elimination rule so that it can eliminate multiple nested or permissions in one step. That is, the or elimination rule can now eliminate a right-nested disjunction of the form
p1 or (p2 or (... or pn))
into then
different casesp1
,p2
, ...,pn
in one step. The translation of multi-way or elimination uses a single multi-way sum elimination function calledeithers
. The benefit of this change is that it reduces the size of the extracted Coq specifications when there are disjunctive types with many cases, such as a Rust enum type with a large number of constructors, because those types used to requiren-1
nested calls to theeither
elimination function, each of which had to duplicate all of the types being eliminated.