-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress on Mr. Solver SHA512 example #1661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-yac
added
subsystem: heapster
Issues specifically related to memory verification using Heapster
subsystem: MRSolver
Issues related to the Mr. Solver monadic-recursive solver in Heapster
labels
May 11, 2022
eddywestbrook
approved these changes
May 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good, thanks Matt!
eddywestbrook
added
the
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
label
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
subsystem: heapster
Issues specifically related to memory verification using Heapster
subsystem: MRSolver
Issues related to the Mr. Solver monadic-recursive solver in Heapster
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains initial progress on getting a SHA512 example working with Mr. Solver. Aside from adding this example to the Heapster examples directory, it contains the following changes.
smtNormPrims
forgenBVVecFromVec
of a vector literal, which turns the term into agenBVVec
of a large chain ofite
s. It also involved adding more general cases foratM
andupdateM
to normComp.askMRSolverH
for aBVVec
on one side but aVec
on the other. This involved adding agenFromBVVec
function to the prelude, which is unfolded during the SMT step insmtNormPrims
.getDetVarsClauses
,determinedVars
, etc, instead of keeping track of seen determined vars as aNameSet
, keep track of them as aNameMap
to the list ofDetVarsClause
s they determine. This fixes a bug where a variable was not getting considered determined because the variable which determines it was already seen, but in a context where it was not determined. By keeping track of the determined vars for each seen variable, it allows us to figure our first variable is determined in the former context.suitableAP
such to check that either the borrows of the two permissions are equal or the range [off,len) is not fully borrowed, instead of just the latter. This fixes a bug where we were unable to provex -o x
for a fully borrowed array permissionx
.Sorry this PR is so many changes lumped together! In the future I will try to keep PRs limited to single changes.