Heapster array permission bug fixes #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 5, 2022 07:17
…ginning of the supplied range; fixed llvmMakeSubArray to correctly offset the borrows in the array it returns
eddywestbrook
added
the
subsystem: heapster
…rows it computes as it computes them; fixed case 4 of proveVarLLVMArrayH so that it only uses the unborrowed ranges for permissions on the LHS
m-yac
approved these changes
May 6, 2022
There was a problem hiding this comment.
This looks awesome! Your documentation comment above proveVarLLVMArrayH was incredibly helpful for me in understanding your algorithm. I did get confused in a few places though, and I noted what I thought might've helped me follow along better what was going on. No necessary changes though, if just want to get this merged.
m-yac
approved these changes
May 6, 2022
m-yac
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-works the
proveVarLLVMArrayfunction to address a few infinite loops and other bugs in proving array permissions. It also adds more comments to document what that function is doing. Additionally, the new examplealloc_sum_array_testhas been added toarrays.cto exercise the fixes.