Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed errors and compiler warnings from HintExtract.hs #1654

Merged
merged 2 commits into from
May 3, 2022
Merged

Removed errors and compiler warnings from HintExtract.hs #1654

merged 2 commits into from
May 3, 2022

Conversation

eddywestbrook
Copy link
Contributor

This PR removes a number of compiler warnings from the Heapster file HintExtract.hs. It also changes some calls to error into Either-type exceptions that are caught and reported in the Toplevel monad.

ChrisEPhifer
ChrisEPhifer approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@ChrisEPhifer ChrisEPhifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ChrisEPhifer ChrisEPhifer added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label May 3, 2022
@mergify mergify bot merged commit ccfb560 into master May 3, 2022
@mergify mergify bot deleted the heapster/fix-warnings branch May 3, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisEPhifer ChrisEPhifer ChrisEPhifer approved these changes

@m-yac m-yac Awaiting requested review from m-yac

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddywestbrook @ChrisEPhifer