Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MrSolver] Add support for 'either's #1602

Merged
merged 9 commits into from
Mar 3, 2022
Merged

[MrSolver] Add support for 'either's #1602

merged 9 commits into from
Mar 3, 2022

Conversation

m-yac
Copy link
Contributor

@m-yac m-yac commented Mar 2, 2022

This PR adds support for eithers to Mr. Solver, specifically enabling the refinements is_head |= is_head and is_elem |= is_elem.

Aside from a few other various fixes and tweaks, this PR adds DeriveAnyClass support for TermLike using generics, removing a lot of boilerplate.

@m-yac m-yac added the subsystem: MRSolver Issues related to the Mr. Solver monadic-recursive solver in Heapster label Mar 2, 2022
@m-yac m-yac requested a review from eddywestbrook March 2, 2022 23:30
eddywestbrook
eddywestbrook approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@eddywestbrook eddywestbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like the fancy use of generics to define liftTermLike and substTermLike. How fancy!

@m-yac m-yac added PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run labels Mar 3, 2022
@mergify mergify bot merged commit a44517f into master Mar 3, 2022
@mergify mergify bot deleted the mr-solver/either branch March 3, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddywestbrook eddywestbrook eddywestbrook approved these changes

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: MRSolver Issues related to the Mr. Solver monadic-recursive solver in Heapster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-yac @eddywestbrook