Dictionary translation changes for comparisons #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 15, 2022
|
There's one further improvement we might want to do that this PR does not do: Lexicographic comparisons on vectors are implemented as a right-fold using the |
robdockins
approved these changes
Feb 15, 2022
added 4 commits
February 14, 2022 18:13
Also add similar `slt` field to `SignedCmp` dictionary. These fields are used to simplify the formulas generated by the cryptol-saw-core translator for Cryptol operators like `<` and `<$`, avoiding redundant logical connectives. Fixes #1565.
This makes it so that `<=` can be translated to less-than-or-equal operators in saw-core (e.g. `bvsle` or `intLe`) instead of `not` combined with a strict less-than the other way around.
This should make it possible for `cryptol_ss` to simplify things like `(<)` to `intLt` even when partially applied.
brianhuffman
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the formulas generated by the cryptol-saw-core translator for Cryptol comparison operators like
<=,<, and<$.