-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monadified Cryptol-to-SAWCore translation #1552
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the type of a term; and applying a pi type to an argument
…vel entrypoint monadifyTerm
… current typing context
… MonType and MonKind data structures
… updated the top-level entrypoint to be called monadify instead of monadifyTerm
…ed numAssertEqM as the monadified version of unsafeAssert applied to the Num type
…erm match scTupleValue and scTupleType
…MTyTuple to just MTyPair; and changed monadifyTerm to take an optional type, which allows monadification to do inference when there is a tuple or record selector and we do not have its whole type
… argument term; reorganized the "from" and "to" operations between monadification terms and OpenTerms to avoid these sorts of mistakes in the future
…ursive functions need to line up
…it from normalization
…ifyName to give each uvar a distinct name; removed the case for FunBinds where we have the same function on both sides, since we do not want it to fire when we have, e.g., fixM on both sides
… name of its monadification
…ork on types in sort 1
…tional sequence (i.e., vectors) be strict, in order to make it easier to prove things about them
m-yac
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
m-yac
added
the
subsystem: MRSolver
Issues related to the Mr. Solver monadic-recursive solver in Heapster
label
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for a translation from Cryptol to monadic SAWCore terms. At a high level, the idea is to replace uses of the unsound combinators
fix : (a -> a) -> a
anderror : String -> a
in the translation of cryptol to SAW core with uses of the sound monadic combinatorsfixM : (a -> CompM a) -> CompM a
anderrorM : String -> CompM a
for the "computation monad"CompM
. This will reduce (or maybe even eliminate!) dependence on these unsound combinators in the SAWCore logic, making it more straightforward to translate Cryptol functions into Coq. It will also allow automated proofs about some unbounded Cryptol functions, or equivalence between some unbounded Cryptol specifications and LLVM implementations.This PR also includes initial progress on the monadic-recursive solver (Mr. Solver).