saw-remote-api: Reach parity with SAWScript for global option settings #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
added
type: enhancement
RyanGlScott
commented
Dec 8, 2021
RyanGlScott
commented
Dec 8, 2021
m-yac
approved these changes
Dec 10, 2021
This adds a `set_option` function to the `saw_client` module that controls whether various global SAW options should be enabled or disabled. The possible options that can be controlled are found in the `saw_client.option` module. Fixes #1493.
RyanGlScott
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits that bring
saw-remote-apiand the Pythonsaw-clientlibrary within feature parity of what SAWScript can do with its global settings (e.g.,{enable,disable}_lax_pointer_ordering). I have included the commit messages of each individual commit below.saw-client: Support setting SAW options
This adds a
set_optionfunction to thesaw_clientmodule that controls whether various global SAW options should be enabled or disabled. The possible options that can be controlled are found in thesaw_client.optionmodule.Fixes #1493.
Add What4 eval to saw-remote-api and saw-client
The infrastructure for doing so was already in place in
saw-remote-api, and thanks to #1493, the infrastructure for adding this functionality in the Pythonsaw-clientlibrary is now in place as well.Fixes #1537.