Heapster permIndicesForProvingOffset using llvmPermContainsArray #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tches on the left to check not only for a syntactic array permission, but also for a block permission containing an array shape
eddywestbrook
added
the
subsystem: heapster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the
permIndicesForProvingOffsetfunction, which searches for a permission on the left that could be used to prove a specific offset on the right. Previously, this function required a "precise" match unless the permission being considered on the left was anarraypermission, but this ignores the possibility that the permission on the left could be amemblockpermission containing an array shape. This PR fixes this issue, which allows thesha512example to type-check.