Coq translator: efficient array and integer literals #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddywestbrook
added
the
subsystem: saw-core-coq
|
Well, drat, the change to the nat literals messes with some of our existing Heapster proofs if it happens for natural numbers like 64 that we are explicitly using in some of our specs. And anyway, Coq doesn't complain until the nats get up into the thousands. So I'm changing "too big" for nat literals to be greater than 1,000. |
brianhuffman
force-pushed
the
saw-core-coq/efficient-arrays-int-lits
branch
from
15ac002 to
668f357
Compare
brianhuffman
approved these changes
Dec 2, 2021
eddywestbrook
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the SAW-core-to-Coq translator would translate array literals to successive applications of the
Vector.consconstructor, which is really slow for large arrays. This PR changes the translation of array literals to useVector.of_listof Coq list literals, which seems to be much faster for large vectors.Additionally, this PR changes the translation of natural number literals that are big enough (currently defined as greater than 20) to explicitly convert from the Coq integer notation rather than use the natural number notation. Note that Coq already does this anyway under the hood but prints a warning, so this change really just gets rid of the warning.