More Heapster lifetime debugging #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 12, 2021 09:57
…ants to signed instead of unsigned integers and not printing the +0 at the end for a 0 constant portion; also added tracing for proving lowned permissions that prints out the needed permissions before the implication prover tries to prove them
…ock on the right-hand side, so that bvDeleteRanges works correctly
… into heapster/more-lifetime-debugging
eddywestbrook
added
the
subsystem: heapster
m-yac
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in Heapster that relate to lifetimes:
SImpl_SplitLifetimerule, which was addingLOwnedPerms in the wrong order, leading to a translation error in type-checking proofs that split lifetimes; andsolveForPermListImplBlockto require a known range for the block on the right-hand side, so thatbvDeleteRangesworks correctly.In addition, this PR also made the pretty-printer for bv expressions nicer, by converting constants to signed instead of unsigned integers and not printing the +0 at the end for a 0 constant portion, and added tracing for proving
lownedpermissions that prints out the needed permissions before the implication prover tries to prove them.