Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upper bound on aeson version #1486

Merged
merged 2 commits into from
Oct 20, 2021
Merged

upper bound on aeson version #1486

merged 2 commits into from
Oct 20, 2021

Conversation

pnwamk
Copy link
Contributor

@pnwamk pnwamk commented Oct 20, 2021

Aeson v2.0 changed some of the data representations (see Changelog). For now, adding a strict upper bound may help mitigate build breakages affected by this. A more thorough fix could be added as well and/or later. (See GaloisInc/argo#188)

@pnwamk pnwamk mentioned this pull request Oct 20, 2021
Copy link
Contributor

@jpaykin jpaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix works for me and builds without errors

@pnwamk pnwamk added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Oct 20, 2021
@mergify mergify bot merged commit 9aa1f01 into master Oct 20, 2021
@mergify mergify bot deleted the aeson-upper-bounds branch October 20, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants