[Heapster] Reformat heapster SAW scripts using multi-line strings #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also: use int64<> when possible, try to keep lines under 80 chars
eddywestbrook
approved these changes
Oct 13, 2021
m-yac
added
the
subsystem: heapster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the readability of the heapster example SAW scripts by using multi-line strings and additional line breaks. Additionally, I used
int64<>where possible, and generally tried to keep every line under 80 chars. I applied this reformatting to commented-out lines as well.Happy to iterate on this PR a bit if you have different preferences for where line breaks should be placed @eddywestbrook