Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1472 by depending on hashable-1.3.4.0 or later #1474

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Fix #1472 by depending on hashable-1.3.4.0 or later #1474

merged 1 commit into from
Oct 11, 2021

Conversation

RyanGlScott
Copy link
Contributor

Issue #1472 is caused by saw-core defining an orphan Hashable instance for Map that clashes with an instance introduced in hashable-1.3.4.0. To fix the issue, simply depend on hashable-1.3.4.0 or later to ensure that the instance is always available, which allows removing the orphan instance entirely.

Fixes #1472.

Issue #1472 is caused by `saw-core` defining an orphan `Hashable` instance
for `Map` that clashes with an instance introduced in `hashable-1.3.4.0`. To
fix the issue, simply depend on `hashable-1.3.4.0` or later to ensure that the
instance is always available, which allows removing the orphan instance
entirely.

Fixes #1472.
Copy link
Contributor

@robdockins robdockins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. My only concern is that hashable 1.3.4 is pretty new. Will we run into compatibility issues? It seems like no, since CI is passing.

@RyanGlScott
Copy link
Contributor Author

hashable-1.3.* is the current major release series, so I wouldn't expect any compatibility issues with other libraries. This is why I felt bold enough to just require a more recent version instead of using CPP.

@RyanGlScott RyanGlScott added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Oct 11, 2021
@mergify mergify bot merged commit 550951d into master Oct 11, 2021
@mergify mergify bot deleted the T1472 branch October 11, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

saw-core fails to build with hashable-1.3.4.0 or later
2 participants