Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix offline_*_external proof tactics #1463

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Fix offline_*_external proof tactics #1463

merged 2 commits into from
Sep 23, 2021

Conversation

atomb
Copy link
Contributor

@atomb atomb commented Sep 22, 2021

These were generating invalid Verilog containing ! characters in names. These are now replaced with _ by updating to a newer version of what4.

@atomb atomb added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Sep 22, 2021
@mergify mergify bot merged commit 03f663a into master Sep 23, 2021
@mergify mergify bot deleted the at-offline-external branch September 23, 2021 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdockins robdockins robdockins approved these changes

@brianhuffman brianhuffman Awaiting requested review from brianhuffman

@kquick kquick Awaiting requested review from kquick

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atomb @robdockins