Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update submodules. #1403

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Update submodules. #1403

merged 1 commit into from
Aug 20, 2021

Conversation

brianhuffman
Copy link
Contributor

No description provided.

@brianhuffman brianhuffman added the PR: submodule bump Pull requests that include a submodule bump label Aug 4, 2021
@brianhuffman brianhuffman requested a review from atomb August 4, 2021 00:48
@brianhuffman
Copy link
Contributor Author

It looks like a bunch of the saw-remote-api tests are failing with errors like FileNotFoundError or ModuleNotFoundError. I don't know if that's a real failure or just a transient server problem.

@RyanGlScott
Copy link
Contributor

It's a Real Failure, but one that's happening on other PRs (example). My understanding is that #1402 aims to address this issue.

@RyanGlScott RyanGlScott mentioned this pull request Aug 4, 2021
Closed
@brianhuffman
Copy link
Contributor Author

Ok, in that case I guess I'll just wait for the other PR to be merged before this one.

atomb
atomb approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me if we can get CI to pass once we rebase this on top of a fixed build system that works for anything... I'm working on it!

@brianhuffman brianhuffman added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Aug 5, 2021
@brianhuffman brianhuffman merged commit d76cdf4 into master Aug 20, 2021
@mergify mergify bot deleted the update-deps branch August 20, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomb atomb atomb approved these changes

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run PR: submodule bump Pull requests that include a submodule bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianhuffman @RyanGlScott @atomb