Update SBV #1398
Merged
Update SBV #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdockins
added
the
PR: submodule bump
atomb
approved these changes
Aug 2, 2021
There was a problem hiding this comment.
Assuming we can get CI to finish, I think this is a great improvement. I should note, however, that I've seen issues with non-termination building 8.15 locally (not just in CI) with GHC 8.10. I haven't concluded whether it's a specific point release (only 8.10.5?) or the whole series. And it's possible that it does terminate, but takes more than an hour or so.
robdockins
added
the
PR: ready to merge
robdockins
removed
PR: ready to merge
robdockins
force-pushed
the
update-sbv
branch
from
71ef04f to
5056038
Compare
robdockins
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been avoiding updating SBV versions for quite awhile now due to an API-breaking change in SBV 8.9 (IIRC). This PR updates across that boundary.