Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java support to RPC API #1397

Merged
merged 11 commits into from
Sep 14, 2021
Merged

Add Java support to RPC API #1397

merged 11 commits into from
Sep 14, 2021

Conversation

atomb
Copy link
Contributor

@atomb atomb commented Jul 26, 2021

  • Adds RPC methods to support Java verification, including to:
    • load a class
    • assume that a method satisfies a contract
    • verify that a method satisfies a contract
  • Adds Python client libraries to support Java verification
  • Adds a basic test of Java verification functionality
  • Adds support for the Java CLASSPATH environment variable in both saw and saw-remote-api

@atomb atomb requested a review from pnwamk July 26, 2021 17:19
Copy link
Contributor

@pnwamk pnwamk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. The few things you and I noted (e.g., fill out TODOs, consider adding a test for the other function) probably worth knocking out before a merge.

@atomb atomb added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Jul 26, 2021
@atomb
Copy link
Contributor Author

atomb commented Jul 30, 2021

I'm in the process of fixing build issues in a separate PR. Once that's merged, I'll rebase this one and hope it works.

@mergify mergify bot merged commit 337ca6c into master Sep 14, 2021
@mergify mergify bot deleted the at-rpc-java branch September 14, 2021 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants