Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heapster-saw: Use LLVM debug information to choose permission variable names #1385

Merged
merged 3 commits into from
Jul 21, 2021
Merged

heapster-saw: Use LLVM debug information to choose permission variable names #1385

merged 3 commits into from
Jul 21, 2021

Conversation

glguy
Copy link
Member

@glguy glguy commented Jul 21, 2021

@eddywestbrook I think this makes sense as a starting point for the feature. What do you think?

@glguy glguy requested a review from eddywestbrook July 21, 2021 15:55
@glguy glguy self-assigned this Jul 21, 2021
eddywestbrook
eddywestbrook approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@eddywestbrook eddywestbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Eric!

The only thing I would say is that I generally use Constant from Data.Functor.Constant where you use Ignore. Maybe it would be nice to use the same one? (So it can be Constant / Ignored, get it?)

@eddywestbrook
Copy link
Contributor

Awesome, thanks Eric! Ship it!

@glguy glguy merged commit d2b99ca into master Jul 21, 2021
@glguy glguy deleted the glguy/dbg-permissions branch July 21, 2021 22:26
@RyanGlScott RyanGlScott mentioned this pull request Jul 21, 2021
Closed
@m-yac m-yac added the subsystem: heapster Issues specifically related to memory verification using Heapster label Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddywestbrook eddywestbrook eddywestbrook approved these changes

Assignees

@glguy glguy

Labels
subsystem: heapster Issues specifically related to memory verification using Heapster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glguy @eddywestbrook @m-yac