Add support for memoized streams to the term model evaluator #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdockins
force-pushed
the
term-model-fix
branch
from
67badc2 to
86b6471
Compare
atomb
approved these changes
Jul 23, 2021
Although it is correct to treat streams according to their SAWCore datatype definition, the naive implementation as a function looses sharing that users expect given the behavior of Cryptol streams. This patch makes sure to memoize concrete evaluations of stream values, and blocks evaluation of stream lookups for values that are not concrete. This significantly improves the performance of the kinds of stream programs that arise from Cryptol.
robdockins
force-pushed
the
term-model-fix
branch
from
fa9cc39 to
f582f67
Compare
robdockins
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it is correct to treat streams according to their
SAWCore datatype definition, the naive implementation as a function
looses sharing that users expect given the behavior of Cryptol
streams. This patch makes sure to memoize concrete evaluations
of stream values, and blocks evaluation of stream lookups for
values that are not concrete.
This significantly improves the performance of the kinds of
stream programs that arise from Cryptol.