Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new experimental term_theories operation #1366

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Conversation

robdockins
Copy link
Contributor

Evaluates a term into a proof obligation via What4 and examines
what logical theories would be required to attempt a proof
of the property. The names of the required theories are computed
and returned to the user.

@robdockins robdockins force-pushed the smt-theories branch 2 times, most recently from 4c10fa9 to dfb31bf Compare July 1, 2021 23:41
@robdockins
Copy link
Contributor Author

This PR addresses #1340. It is not yet completely accurate because of GaloisInc/what4#139. This means that terms requiring uninterpreted functions will be reported as not requiring any SMT theories. We will need to fix and update the What4 submodule to close this gap.

@robdockins robdockins requested a review from atomb July 14, 2021 17:26
@robdockins robdockins marked this pull request as ready for review July 14, 2021 17:26
@robdockins
Copy link
Contributor Author

I think it makes sense to merge this before we fix GaloisInc/what4#139 and update afterewards.

@robdockins robdockins requested a review from brianhuffman July 14, 2021 17:58
@robdockins robdockins added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Jul 14, 2021
Evaluates a term into a proof obligation via What4 and examines
what logical theories would be required to attempt a proof
of the property.  The names of the required theories are computed
and returned to the user.
@robdockins
Copy link
Contributor Author

Failed SIKE test is some kind of caching error. I'm going to merge anyway since the 8.10.3 version passed.

@robdockins robdockins merged commit 844a5bb into master Jul 14, 2021
@mergify mergify bot deleted the smt-theories branch July 14, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants