Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define recursive Heapster shapes from recursive Rust types #1357

Merged
merged 3 commits into from
Jun 28, 2021

Conversation

eddywestbrook
Copy link
Contributor

This updates the heapster_define_rust_type command, that defines Heapster shapes from Rust types, so that it can handle recursive Rust types, such as the List type

pub enum List<X> { Nil, Cons (X,Box<List<X>>) }

Note: this code represents a branch of both saw-script and heapster-saw that was not merged before Heapster was merged into saw-script master.

@eddywestbrook eddywestbrook added the subsystem: heapster Issues specifically related to memory verification using Heapster label Jun 25, 2021
Copy link
Member

@ChrisEPhifer ChrisEPhifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me! Assuming this all builds / runs successfully on our rust_data example(s), this should be good to merge in :)

@eddywestbrook eddywestbrook added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Jun 28, 2021
@mergify mergify bot merged commit ec8a060 into master Jun 28, 2021
@mergify mergify bot deleted the rust-recursive-types-redo branch June 28, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: heapster Issues specifically related to memory verification using Heapster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants