Toplevel ioref #1349
Merged
Toplevel ioref #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 21, 2021 19:22
Previously it used `StateT TopLevelRW IO`. This change will make it possible to preserve state changes that have been made before an exception is thrown.
Also reimplement the `REPL` monad to adapt to this change. This makes it so that the `REPL` monad can also preserve state changes when an exception is thrown in a `TopLevel` action. Fixes #1341.
brianhuffman
force-pushed
the
toplevel-ioref
branch
from
cd59135 to
8cef807
Compare
atomb
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplement
TopLevelmonad usingReaderT (IORef TopLevelRW) IOinstead ofStateT TopLevelRW IO. This makes it possible to preserve state changes that have been made before an exception is thrown.Fixes #1341.