Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete requirements.tx, rely solely on poetry.lock #1323

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

pnwamk
Copy link
Contributor

@pnwamk pnwamk commented Jun 7, 2021

Because we use poetry to manage the dependencies for the saw
python client we do not wish to also have a checked in
requirements.txt. Instead we use the poetry.lock file to be the
one place to keep up-to-date dependency details, and we can
generate requirements.txt on an as-needed basis using the
poetry command:

poetry export -f requirements.txt --output requirements.txt

Because we use poetry to manage the dependencies for the saw
python client we do not wish to also have a checked in
requirements.txt. Instead we use the poetry.lock file to be the
one place to keep up-to-date dependency details, and we can
generate requirements.txt on an as-needed basis using the
poetry command:
```
poetry export -f requirements.txt --output requirements.txt
```
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. YES.

@pnwamk pnwamk merged commit c9ce595 into master Jun 8, 2021
@pnwamk pnwamk deleted the remove-py-requirements-txt branch June 8, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants