Set and use writability permission bits on JVM static fields #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 14, 2021 14:05
- jvm_modifies_field - jvm_modifies_static_field - jvm_modifies_elem
Currently these tests are configured as known failures; the tests will need to be updated when the bugs are fixed.
brianhuffman
force-pushed
the
jvm-static-field-writable
branch
from
eb99262 to
7aa7301
Compare
brianhuffman
added
the
PR: ready to merge
atomb
reviewed
May 14, 2021
| fails (jvm_verify c "set" [] false set_spec_1 z3); | ||
|
|
||
| // It should be impossible to verify the bogus set_spec_2. | ||
| // FIXME: this should fail |
There was a problem hiding this comment.
Am I right in understanding that making this fail, as it should, is the "second half" of #1290?
There was a problem hiding this comment.
That's exactly right.
atomb
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates crucible to include GaloisInc/crucible#733. Fixes #1066.
Note: This is the first half of the draft PR #1290; it includes the subset of the crucible changes that have been merged so far.