Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve errors when a non-function is applied to an argument #1218

Merged
merged 3 commits into from
Apr 28, 2021
Merged

Improve errors when a non-function is applied to an argument #1218

merged 3 commits into from
Apr 28, 2021

Conversation

brianhuffman
Copy link
Contributor

Ported from GaloisInc/saw-core#198.

@brianhuffman brianhuffman added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Apr 27, 2021
@brianhuffman brianhuffman mentioned this pull request Apr 27, 2021
Closed
@m-yac
Copy link
Contributor

m-yac commented Apr 28, 2021

Looks like the CI is failing because of some issue with yices? The saw-remote-api and cabal-test checks look like they all fail on:

command -v yices

and the "Test s2n proofs" checks look like they all fail on:

Resolving yices.csl.sri.com (yices.csl.sri.com)... failed: Temporary failure in name resolution.
wget: unable to resolve host address 'yices.csl.sri.com'

Am I interpreting this right?

@brianhuffman brianhuffman requested a review from m-yac April 28, 2021 20:17
@brianhuffman
Copy link
Contributor Author

This yices failure is, I believe, a problem with downloading and installing the yices binary on the build machine. It's a transient error that's not our fault.

@brianhuffman
Copy link
Contributor Author

brianhuffman commented Apr 28, 2021 •
edited
Loading

I just restarted CI; hopefully the yices download will work this time. @m-yac if you want to give a quick approving review this can get merged as soon as CI finishes successfully (empty review is fine).

@mergify mergify bot merged commit 7b8c134 into master Apr 28, 2021
@mergify mergify bot deleted the feature/improve-NotFuncType-error branch April 28, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-yac m-yac m-yac approved these changes

@eddywestbrook eddywestbrook Awaiting requested review from eddywestbrook

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianhuffman @m-yac