Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote-api: python client depend on PyPI cryptol package #1154

Merged
merged 1 commit into from
Apr 19, 2021
Merged

remote-api: python client depend on PyPI cryptol package #1154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions saw-remote-api/python/poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion saw-remote-api/python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ authors = ["Andrew Kent <[email protected]>", "Aaron Tomb <[email protected]>"]
python = "^3.8"
requests = "^2.25.1"
BitVector = "^3.4.9"
cryptol = { path = "../../deps/cryptol/cryptol-remote-api/python/", develop = true }
cryptol = "2.11.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did version 2.11.0 make it to PyPI before GaloisInc/cryptol#1135 landed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no automation/CI/etc inherently linking the cryptol repo and that PR to the PyPI upload/package. I think changing that so it is more automated and less manual would be an improvement, but it hasn't been implemented yet.

In other words, I pushed the PyPI package before merging that PR so I could further test and check things had worked out as expected, with the thought that if there was a needed change it would become a part of that PR and then a subsequent PyPI package patch/update.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. I suppose I was confused since I associate PyPI releases with git tags, but now that I check, there doesn't seem to be a convention that a given PyPI release of cryptol corresponds to a particular tag in the cryptol repo.

argo-client = "0.0.4"

[tool.poetry.dev-dependencies]
Expand Down