Remove eq #1114
Merged
Remove eq #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the merge conflicts should be resolved by simply rebasing this branch. |
|
Yeah, I think you're right. I'm not quite ready to merge this yet, I'm still trying to fix up the proof breakages caused by this, and it's slow going. |
brianhuffman
approved these changes
Mar 10, 2021
|
Make sure you're working with the latest version of the |
robdockins
force-pushed
the
remove-eq
branch
2 times, most recently
from
046bd5e to
e2a5eb9
Compare
The tuple _value_ constructor was being used instead of the tuple _type_ constructor, which was causing an ill-typed term to be emitted. Fixes #1119
operation. This requires some minor fixups to the ECDSA proof.
This was referenced Mar 11, 2021
robdockins
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the dodgy
eqsaw-core primitive. This causes some minor breakages in proofs that we'll need to fix up.