Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update submodule versions. #1074

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Update submodule versions. #1074

merged 1 commit into from
Feb 15, 2021

Conversation

brianhuffman
Copy link
Contributor

No description provided.

@brianhuffman brianhuffman linked an issue Feb 13, 2021 that may be closed by this pull request
Proper error handling in JVM bytecode parser #924
Closed
@brianhuffman brianhuffman mentioned this pull request Feb 13, 2021
Closed
@brianhuffman brianhuffman requested a review from atomb February 14, 2021 23:40
@brianhuffman brianhuffman added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Feb 15, 2021
@atomb
Copy link
Contributor

atomb commented Feb 15, 2021

I believe this will break the test suite for saw-remote-api. That test suite is currently allowed to fail, but I've been hoping to make it blocking soon. The reason this affects it is that the updated submodule for argo deletes the Python client libraries that @pnwamk just moved to galois-py-toolkit, but this PR doesn't add that new repo as a submodule. It might be something we want to do in an upcoming PR, rather than holding this one up, but I at least wanted to note the issue.

@brianhuffman
Copy link
Contributor Author

@atomb To avoid introducing any new problems, I'll just reset this branch to exclude the last two commits; then it will still have the argo-python package.

@mergify mergify bot merged commit a2010f4 into master Feb 15, 2021
@mergify mergify bot deleted the update-deps branch February 15, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomb atomb atomb approved these changes

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proper error handling in JVM bytecode parser
2 participants
@brianhuffman @atomb