-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GHC and package dependency version pinning #1025
Conversation
As far as why this is failing on Windows in particular, see http://hackage.haskell.org/package/hsc2hs-0.68.7/hsc2hs.cabal. To work around a Windows-specific One possible way to fix this would be to re- |
4705f2d
to
d836f04
Compare
d836f04
to
f41f92a
Compare
This looks sensible, although I worry that we'll have similar difficulties later when we try to update the |
I ultimately want this to be completely automated, and think it could be, but it'll take more work, and until we do at least part of this commit we can't build using GHC 8.10.3, which it's important for us to be able to do. What I'd like in the long run would be to have some sort of automated process that would try running There were some manual changes needed here because of some reorganization we've been doing. After this merge, I think the only manual changes would be to remove platform-specific entries. Alternatively, we could have separate freeze files for Windows (which we've done in the past), which should eliminate any need to do manual work. |
OK. I'm fine with merging this as-is, but I do think it's worth writing down what the platform-specific packages are somewhere, as that could save someone else some pain down the road. |
Yes, that's a very good point. I just pushed a commit to the README outlining what packages to leave out of freeze files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Now that we have Mergify enabled, I'm going to try to see if I can get this automatically merged once CI passes by applying the new "ready-to-merge" label.
Whee! That'll be awesome. :) I'm so happy to have Mergify. |
@atomb: So #1059 got merged first, and now this one's out of date with master. I think we need a "keep-updated" label if we want Mergify to automatically rebase and restart the CI when that happens. (That label doesn't exist yet; we should double check to make sure we name it the right thing.) Also, I see some CI failures with the message "Error: retrieving gpg key timed out" which probably have nothing to do with this PR. |
No description provided.