Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure in test_tutorial5 #511

Closed
atomb opened this issue Jun 27, 2019 · 1 comment · Fixed by #565
Closed

Failure in test_tutorial5 #511

atomb opened this issue Jun 27, 2019 · 1 comment · Fixed by #565
Milestone

Comments

@atomb
Copy link
Contributor

atomb commented Jun 27, 2019

Running the tests in intTests/test_tutorial5 currently fails with a log ending in

[16:37:33.347] Loading file "/Users/atomb/galois/saw-script/intTests/test_tutorial5/tmp/des3.saw"
[warning] at ./DES.cry:25:9--25:13
    This binding for last shadows the existing binding from
    (at /var/folders/n8/s7z9ns8d4k39v2y_2sn__12m0000gp/T/Cryptol91292-0.cry:561:1--561:5, last)
[warning] at ./DES.cry:25:16--25:38:
  Defaulting type argument 'ix' of '(Cryptol::@)' to max 1
                                                         (width ?n`1054)
  where
  ?n`1054 is length of comprehension generator at ./DES.cry:22:15--24:35
[16:37:33.444] proving dec_enc...
[16:37:37.201] Valid
[16:37:37.201] proving enc_dec...
[16:37:41.307] Valid
[16:37:41.307] Theorem (let { x@1 = Prelude.Vec 64 Prelude.Bool
    }
 in (key : x@1)
-> (msg : x@1)
-> Prelude.EqTrue (prop2 key msg))
[16:37:41.337] proving dec3_enc3...
[16:37:41.369] ruleOfProp: Predicate not an equation: prop1 !1 !0
CallStack (from HasCallStack):
  error, called at src/Verifier/SAW/Rewriter.hs:306:16 in saw-core-0.1-LR0ijpUgX5Z4WRirnlruYt:Verifier.SAW.Rewriter
@atomb atomb added this to the 1.0 milestone Jun 27, 2019
@atomb atomb modified the milestones: 1.0, 0.4 Oct 1, 2019
@brianhuffman
Copy link
Contributor

As far as I can tell, the problematic sawscript file doc/tutorial/code/des3.saw has never worked. (It has never been modified since it was added in commit 2890780.) Also, it clearly shouldn't work, as it tries to use a theorem of the form forall x y, prop1 x y (which is not an equation) as a rewrite rule. des3.saw should be rewritten to make it work properly.

atomb pushed a commit that referenced this issue Oct 15, 2019
Ptival pushed a commit that referenced this issue Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants