Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

saw-core: Duplicate axioms bvNat_bvToNat and bvNat_bvToNat_id #1785

Closed
RyanGlScott opened this issue Dec 12, 2022 · 1 comment
Closed

saw-core: Duplicate axioms bvNat_bvToNat and bvNat_bvToNat_id #1785

RyanGlScott opened this issue Dec 12, 2022 · 1 comment
Assignees
@RyanGlScott
Labels
subsystem: saw-core Issues related to the saw-core representation or the saw-core subsystem tech debt Issues that document or involve technical debt

Comments

@RyanGlScott
Copy link
Contributor

Currently, Prelude.sawcore contains these axioms:

saw-script/saw-core/prelude/Prelude.sawcore

Lines 3156 to 3160 in 8f72532

axiom bvNat_bvToNat : (n : Nat)
-> (x : Vec n Bool)
-> Eq (Vec n Bool)
(bvNat n (bvToNat n x))
x;

saw-script/saw-core/prelude/Prelude.sawcore

Lines 1221 to 1222 in 8f72532

axiom bvNat_bvToNat_id : (n : Nat) -> (x : Vec n Bool) ->
Eq (Vec n Bool) (bvNat n (bvToNat n x)) x;

As far as I can tell, these axioms are duplicates. Since bvNat_bvToNat was added before bvNat_bvToNat_id, I propose removing the latter in favor of the former.
@RyanGlScott RyanGlScott added tech debt Issues that document or involve technical debt subsystem: saw-core Issues related to the saw-core representation or the saw-core subsystem labels Dec 12, 2022
@RyanGlScott RyanGlScott self-assigned this Dec 12, 2022
@eddywestbrook
Copy link
Contributor

Agreed, these do seem like duplicates, and it does make sense to remove the most recently added

RyanGlScott added a commit that referenced this issue Dec 12, 2022
@RyanGlScott
saw-core: Use bvNat_bvToNat over bvNat_bvToNat_id
fef1087 
To avoid unnecessary breakage in the Coq support libraries, we keep
`bvNat_bvToNat_id` around as a deprecated alias for `bvNat_bvToNat`.

Fixes #1785.
@mergify mergify bot closed this as completed in 17eb56e Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanGlScott RyanGlScott

Labels
subsystem: saw-core Issues related to the saw-core representation or the saw-core subsystem tech debt Issues that document or involve technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eddywestbrook @RyanGlScott