Duplicate SAW artifacts uploaded in CI

[RyanGlScott]

While looking at the CI recently, I noticed this very strange pattern:

saw-script/.github/workflows/ci.yml

Lines 193 to 203 in af4e2e5

	- if: "matrix.ghc == '8.10.7'"
	uses: actions/upload-artifact@v2
	with:
	path: dist/bin
	name: ${{ runner.os }}-bins
	- if: "matrix.os == 'ubuntu-18.04'"
	uses: actions/upload-artifact@v2
	with:
	name: "saw-${{ runner.os }}-${{ matrix.ghc }}"
	path: "dist/bin/saw"

The first of these upload-artifact rules (at dist/bin) uploads everything in dist/bin. This artifact is later used in several of the test jobs, which is reasonable. The second of these upload-artifact rules, however, uploads specifically dist/bin/saw. This is odd, since that executable is already contained within the first dist/bin artifact, so this is duplicated work.

As far as I can tell, the only place where this second uploaded artifact is used is in the s2n-tests job:

saw-script/.github/workflows/ci.yml

Lines 536 to 548 in af4e2e5

	- name: Download previously-built SAW
	uses: actions/download-artifact@v2
	with:
	name: "saw-Linux-${{ matrix.ghc }}"
	path: ./s2nTests/bin
	- shell: bash
	working-directory: s2nTests
	run: |
	curl -o solvers-bin.zip -sL "https://github.com/GaloisInc/what4-solvers/releases/download/$SOLVER_PKG_VERSION/ubuntu-18.04-bin.zip"
	(cd bin && unzip ../solvers-bin.zip)
	docker-compose pull
	grep -h '^FROM' docker/*.dockerfile | sort -u | awk '{print $2}' | xargs -n1 -P8 docker pull

But note that right after downloading the saw executable, it proceeds to re-download all of the SMT solvers. In fact, if you summed up the saw executable plus the SMT solvers, you would get precisely what is contained within the dist/bin artifact! So it would be far more direct to just download that artifact rather than go through all of the huffing and puffing needed currently in s2n-tests.