Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Coq Ident type into a newtype #1253

Open
brianhuffman opened this issue Dec 2, 2020 · 0 comments
Open

Make Coq Ident type into a newtype #1253

brianhuffman opened this issue Dec 2, 2020 · 0 comments
Assignees
@benjaminselfridge
Labels
subsystem: saw-core-coq Issues related to converting saw-core to Gallina for use with the Coq/Rocq theorem prover tech debt Issues that document or involve technical debt type: enhancement Issues describing an improvement to an existing feature or capability
Milestone
Someday

Comments

@brianhuffman
Copy link
Contributor

Making the Coq Ident type into a type that is distinct from String would help to avoid the kind of bugs that aba230b68bf06700e845d00f452e5c7230342483 is trying to fix, where in the translator code we simply forgot to translate some of the bound names. (See comments on GaloisInc/saw-core-coq#29.)

Another advantage of having an abstract type is that we could freely change its representation later (e.g. to Text). It would also make the code arguably easier to understand and to maintain.
@brianhuffman brianhuffman transferred this issue from GaloisInc/saw-core-coq Jan 21, 2021
@brianhuffman brianhuffman transferred this issue from GaloisInc/saw-core Apr 27, 2021
@brianhuffman brianhuffman added subsystem: saw-core-coq Issues related to converting saw-core to Gallina for use with the Coq/Rocq theorem prover tech debt Issues that document or involve technical debt labels Apr 27, 2021
brianhuffman pushed a commit that referenced this issue Apr 27, 2021
Introduce newtype for Coq.Ident type.
e49432e 
Fixes #1253.
@brianhuffman brianhuffman mentioned this issue Apr 27, 2021
Closed
@sauclovian-g sauclovian-g added the type: enhancement Issues describing an improvement to an existing feature or capability label Oct 30, 2024
@sauclovian-g sauclovian-g added this to the Someday milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjaminselfridge benjaminselfridge

Labels
subsystem: saw-core-coq Issues related to converting saw-core to Gallina for use with the Coq/Rocq theorem prover tech debt Issues that document or involve technical debt type: enhancement Issues describing an improvement to an existing feature or capability
Projects
None yet
Milestone
Someday
Development

Successfully merging a pull request may close this issue.

Introduce newtype for Coq.Ident type. GaloisInc/saw-script
3 participants
@brianhuffman @benjaminselfridge @sauclovian-g