Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infelicities surrounding SAW's support for PtrTo in LLVM #1132

Closed
RyanGlScott opened this issue Mar 16, 2021 · 0 comments · Fixed by #1133
Closed

Infelicities surrounding SAW's support for PtrTo in LLVM #1132

RyanGlScott opened this issue Mar 16, 2021 · 0 comments · Fixed by #1133
Assignees
Labels
subsystem: crucible-llvm Issues related to LLVM bitcode verification with crucible-llvm subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings

Comments

@RyanGlScott
Copy link
Contributor

RyanGlScott commented Mar 16, 2021

If you want to construct and LLVMType representing a pointer (i.e., llvm-pretty's PtrTo), then you're going to hit one of the following difficulties:

  • The Python bindings have a ptr function, but in practice, it's broken. The SAW remote API dictates that the field accompanying the pointer tag be named to type, but the Python bindings use a field named points to.
  • SAWScript doesn't have an equivalent to ptr at all. The closest thing it has is the llvm_type function (e.g., llvm_type "i64*"), but we should have a separate llvm_pointer : LLVMType -> LLVMType function for constructing PtrTos directly.

It should be relatively straightforward to solve both of these, so I'll optimistically assign myself.

@RyanGlScott RyanGlScott added subsystem: crucible-llvm Issues related to LLVM bitcode verification with crucible-llvm subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings labels Mar 16, 2021
@RyanGlScott RyanGlScott self-assigned this Mar 16, 2021
@mergify mergify bot closed this as completed in #1133 Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subsystem: crucible-llvm Issues related to LLVM bitcode verification with crucible-llvm subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant