Skip to content
This repository has been archived by the owner on Jun 9, 2021. It is now read-only.

Make ruleOfProp return a Maybe instead of calling error. #112

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

brianhuffman
Copy link
Contributor

This is to facilitate a fix for GaloisInc/saw-script#319.

Copy link
Contributor

@robdockins robdockins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. Minor nit: I'd prefer to delete the $ in Just $ RewriteRule{ ... } lines. I'm pretty sure they aren't necessary.

@brianhuffman brianhuffman merged commit f61023e into master Dec 9, 2020
brianhuffman pushed a commit to GaloisInc/saw-script that referenced this pull request Dec 9, 2020
This patch includes PR GaloisInc/saw-core#112, which
implements error handling using the Maybe monad for
the creation of rewrite rules from equational theorems.

Fixes #319.
brianhuffman pushed a commit to GaloisInc/saw-script that referenced this pull request Dec 9, 2020
This patch includes PR GaloisInc/saw-core#112, which
implements error handling using the Maybe monad for
the creation of rewrite rules from equational theorems.

Fixes #319.
brianhuffman pushed a commit to GaloisInc/saw-script that referenced this pull request Dec 9, 2020
This patch includes PR GaloisInc/saw-core#112, which
implements error handling using the Maybe monad for
the creation of rewrite rules from equational theorems.

Fixes #319.
@brianhuffman brianhuffman deleted the ruleOfProp branch January 22, 2021 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants