Allow building with GHC 9.4 #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only change needed is to enable `UndecidableInstances` in `Data.Parameterized.Fin`, which is necessary due to GHC 9.4 being pickier about undecidable instance checking. See [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=24540b698481cf2b0bd11029b58eaddc0fbfbb31#stricter-undecidableinstances-checking) of the GHC 9.4 Migration Guide. Fixes #141.
kquick
approved these changes
Nov 21, 2022
RyanGlScott
added a commit
to GaloisInc/bv-sized-float
that referenced
this pull request
Feb 15, 2023
This patch: * Bumps the upper version bounds on `bv-sized` to allow building with a version that supports GHC 9.4. * Bumps the `parameterized-utils` submodule to bring in the changes from GaloisInc/parameterized-utils#146, which is needed to make it build with GHC 9.4.
RyanGlScott
added a commit
to GaloisInc/bv-sized-float
that referenced
this pull request
Mar 21, 2023
This patch: * Bumps the upper version bounds on `bv-sized` to allow building with a version that supports GHC 9.4. * Bumps the `parameterized-utils` submodule to bring in the changes from GaloisInc/parameterized-utils#146, which is needed to make it build with GHC 9.4.
RyanGlScott
added a commit
to GaloisInc/grift
that referenced
this pull request
Mar 22, 2023
This patch: * Bumps the upper version bounds on `bv-sized` to allow building with a version that supports GHC 9.4. * Bumps the following submodules to allow them to build with GHC 9.4: * `bv-sized`: GaloisInc/bv-sized#27 * `bv-sized-float`: GaloisInc/bv-sized-float#4 * `parameterized-utils`: GaloisInc/parameterized-utils#146
RyanGlScott
added a commit
to GaloisInc/dismantle
that referenced
this pull request
Mar 23, 2023
This contains a handful of small tweaks needed to make the libraries in the `dismantle` repo build with GHC 9.4: * I have bumped the upper version bounds on `text` to allow building with `text-2.0.*`, which is bundled with GHC 9.4. * GHC 9.4 is pickier about undecidable instance checking. See [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=24540b698481cf2b0bd11029b58eaddc0fbfbb31#stricter-undecidableinstances-checking) of the GHC 9.4 Migration Guide. As a result, I had to explicitly enable `UndecidableInstances` in `What4.Utils.AbstractDomains` to make it compile. * I have bumped the `parameterized-utils` submodule to bring in the changes from GaloisInc/parameterized-utils#146, which is needed to make it build with GHC 9.4.
RyanGlScott
added a commit
to GaloisInc/dismantle
that referenced
this pull request
Mar 23, 2023
This contains a handful of small tweaks needed to make the libraries in the `dismantle` repo build with GHC 9.4: * I have bumped the upper version bounds on `text` to allow building with `text-2.0.*`, which is bundled with GHC 9.4. * GHC 9.4 is pickier about undecidable instance checking. See [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=24540b698481cf2b0bd11029b58eaddc0fbfbb31#stricter-undecidableinstances-checking) of the GHC 9.4 Migration Guide. As a result, I had to explicitly enable `UndecidableInstances` in `Data.BitMask` to make it compile. * I have bumped the `parameterized-utils` submodule to bring in the changes from GaloisInc/parameterized-utils#146, which is needed to make it build with GHC 9.4.
RyanGlScott
added a commit
to GaloisInc/dismantle
that referenced
this pull request
Mar 23, 2023
This contains a handful of small tweaks needed to make the libraries in the `dismantle` repo build with GHC 9.4: * I have bumped the upper version bounds on `text` to allow building with `text-2.0.*`, which is bundled with GHC 9.4. * GHC 9.4 is pickier about undecidable instance checking. See [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=24540b698481cf2b0bd11029b58eaddc0fbfbb31#stricter-undecidableinstances-checking) of the GHC 9.4 Migration Guide. As a result, I had to explicitly enable `UndecidableInstances` in `Data.BitMask` to make it compile. * I have bumped the `parameterized-utils` submodule to bring in the changes from GaloisInc/parameterized-utils#146, which is needed to make it build with GHC 9.4.
RyanGlScott
added a commit
to GaloisInc/grift
that referenced
this pull request
Mar 24, 2023
This patch: * Bumps the upper version bounds on `bv-sized` to allow building with a version that supports GHC 9.4. * Bumps the following submodules to allow them to build with GHC 9.4: * `bv-sized`: GaloisInc/bv-sized#27 * `bv-sized-float`: GaloisInc/bv-sized-float#4 * `parameterized-utils`: GaloisInc/parameterized-utils#146
RyanGlScott
added a commit
to GaloisInc/macaw-loader
that referenced
this pull request
Apr 18, 2023
This contains a variety of tweaks needed to make the libraries in the `macaw-loader` repo build with GHC 9.4: * GHC 9.4 is pickier about undecidable superclass checking. As such, I needed to explicitly enable `UndecidableSuperClasses` in one place. * The following submodule changes were brought in to support building with GHC 9.4: * `asl-translator`: GaloisInc/asl-translator#51 * `bv-sized`: GaloisInc/bv-sized#27 * `bv-sized-float`: GaloisInc/bv-sized-float#4 * `crucible`: GaloisInc/crucible#1073 (This also requires bumping the `llvm-pretty`, `llvm-pretty-bc-parser`, and `what4` submodules as a side effect) * `dismantle`: GaloisInc/dismantle#40 * `grift`: GaloisInc/grift#8 * `macaw`: TODO RGS * `parameterized-utils`: GaloisInc/parameterized-utils#146 * `semmc`: GaloisInc/semmc#79
RyanGlScott
added a commit
to GaloisInc/macaw-loader
that referenced
this pull request
Apr 18, 2023
This contains a variety of tweaks needed to make the libraries in the `macaw-loader` repo build with GHC 9.4: * GHC 9.4 is pickier about undecidable superclass checking. As such, I needed to explicitly enable `UndecidableSuperClasses` in one place. * The following submodule changes were brought in to support building with GHC 9.4: * `asl-translator`: GaloisInc/asl-translator#51 * `bv-sized`: GaloisInc/bv-sized#27 * `bv-sized-float`: GaloisInc/bv-sized-float#4 * `crucible`: GaloisInc/crucible#1073 (This also requires bumping the `llvm-pretty`, `llvm-pretty-bc-parser`, and `what4` submodules as a side effect) * `dismantle`: GaloisInc/dismantle#40 * `grift`: GaloisInc/grift#8 * `macaw`: GaloisInc/macaw#330 * `parameterized-utils`: GaloisInc/parameterized-utils#146 * `semmc`: GaloisInc/semmc#79
RyanGlScott
added a commit
to GaloisInc/macaw-loader
that referenced
this pull request
Apr 18, 2023
This contains a variety of tweaks needed to make the libraries in the `macaw-loader` repo build with GHC 9.4: * GHC 9.4 is pickier about undecidable superclass checking. As such, I needed to explicitly enable `UndecidableSuperClasses` in one place. * The following submodule changes were brought in to support building with GHC 9.4: * `asl-translator`: GaloisInc/asl-translator#51 * `bv-sized`: GaloisInc/bv-sized#27 * `bv-sized-float`: GaloisInc/bv-sized-float#4 * `crucible`: GaloisInc/crucible#1073 (This also requires bumping the `llvm-pretty`, `llvm-pretty-bc-parser`, and `what4` submodules as a side effect) * `dismantle`: GaloisInc/dismantle#40 * `grift`: GaloisInc/grift#8 * `macaw`: GaloisInc/macaw#330 * `parameterized-utils`: GaloisInc/parameterized-utils#146 * `semmc`: GaloisInc/semmc#79
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Apr 18, 2023
This contains a variety of tweaks needed to build SAW with GHC 9.4: * GHC 9.4 is more conservative about inferring superclass constraints that arise from functional dependencies (see [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=b60e52482a666d25638d59cd7e86851ddf971dc1#constraints-derived-from-superclasses) of the GHC 9.4 Migration Guide), so we must add explicit `m ~ Identity` constraints to certain parts of `heapster-saw` to make it compile with GHC 9.4. * I raised the upper version bounds on `aeson` and `vector` to allow building them with GHC 9.4. * The following submodule changes were brought in to support building with GHC 9.4: * `argo`: #193 * `crucible`: GaloisInc/crucible#1073 (This also requires bumping the `llvm-pretty`, `llvm-pretty-bc-parser`, and `what4` submodules as a side effect) * `language-sally`: GaloisInc/language-sally#13 * `macaw`: GaloisInc/macaw#330 * `parameterized-utils`: GaloisInc/parameterized-utils#146 temp
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Apr 19, 2023
This contains a variety of tweaks needed to build SAW with GHC 9.4: * GHC 9.4 is more conservative about inferring superclass constraints that arise from functional dependencies (see [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=b60e52482a666d25638d59cd7e86851ddf971dc1#constraints-derived-from-superclasses) of the GHC 9.4 Migration Guide), so we must add explicit `m ~ Identity` constraints to certain parts of `heapster-saw` to make it compile with GHC 9.4. * I raised the upper version bounds on `aeson` and `vector` to allow building them with GHC 9.4. * The following submodule changes were brought in to support building with GHC 9.4: * `argo`: #193 * `crucible`: GaloisInc/crucible#1073 (This also requires bumping the `llvm-pretty`, `llvm-pretty-bc-parser`, and `what4` submodules as a side effect) * `language-sally`: GaloisInc/language-sally#13 * `macaw`: GaloisInc/macaw#330 * `parameterized-utils`: GaloisInc/parameterized-utils#146 Fixes #1852.
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
May 26, 2023
This contains a variety of tweaks needed to build SAW with GHC 9.4: * GHC 9.4 is more conservative about inferring superclass constraints that arise from functional dependencies (see [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=b60e52482a666d25638d59cd7e86851ddf971dc1#constraints-derived-from-superclasses) of the GHC 9.4 Migration Guide), so we must add explicit `m ~ Identity` constraints to certain parts of `heapster-saw` to make it compile with GHC 9.4. * I raised the upper version bounds on `aeson` and `vector` to allow building them with GHC 9.4. * The following submodule changes were brought in to support building with GHC 9.4: * `argo`: #193 * `crucible`: GaloisInc/crucible#1073 (This also requires bumping the `llvm-pretty`, `llvm-pretty-bc-parser`, and `what4` submodules as a side effect) * `language-sally`: GaloisInc/language-sally#13 * `macaw`: GaloisInc/macaw#330 * `parameterized-utils`: GaloisInc/parameterized-utils#146 Fixes #1852.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only change needed is to enable
UndecidableInstancesinData.Parameterized.Fin, which is necessary due to GHC 9.4 being pickier about undecidable instance checking. See this section of the GHC 9.4 Migration Guide.Fixes #141.