Only fix personality to (MS.MacawSimulatorState sym) where required. (take two) #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for situations where you want to be able to inspect the personality type in function/syscall lookups.
travitch
approved these changes
Feb 21, 2022
Yes, good point. I'm happy to write the corresponding SAW PR. |
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Feb 21, 2022
This bumps the `macaw` submodule, which brings in changes from GaloisInc/macaw#264. This requires explicitly instantiating the new `personality` type variable of `LookupFunctionHandle` to accommodate.
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Feb 22, 2022
This bumps the `macaw` submodule, which brings in changes from GaloisInc/macaw#264. This requires explicitly instantiating the new `personality` type variable of `LookupFunctionHandle` to accommodate.
mergify bot
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Feb 22, 2022
Bump `macaw` submodule, adapt to GaloisInc/macaw#264
RyanGlScott
added a commit
to GaloisInc/ambient-verifier
that referenced
this pull request
Mar 1, 2023
This bumps the `macaw` submodule, which brings in changes from GaloisInc/macaw#264. This requires explicitly instantiating the new `personality` type variable of `MacawArchEvalFn` and `Lookup{Function,Syscall}Handle` to accommodate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same patch as #203, but rebased and with an additional commit to parameterize
Lookup{Function,Syscall}Handleby thepersonalitytype variable, which proves handy in my particular use case. I've also added another commit to note these changes in themacaw-symbolicchangelog.