Add support for FSBASE and GSBASE registers on x86_64 #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for the FSBASE and GSBASE registers on x86_64. It also lays the groundwork for supporting additional special segment registers on other architectures. It does this by adding a callback `LookupSegmentBasePointer` that takes an `ArchFn` indicating which segment register is being read, and returns a base pointer to that memory segment.
travitch
suggested changes
Sep 10, 2021
There was a problem hiding this comment.
Can we make this just an argument to x86_64MacawEvalFn? The second most common architecture that actually supports segmentation is the AS/400, so I'm inclined to keep details like that out of the core libraries.
That would also make it easier for us to provide a default implementation (i.e., specialized to x86_64).
This commit adds an optional argument to `genArchVals` that allows client code to override the backend translation behavior of `MacawArchStmtExtension`s on a statement-by-statement basis.
travitch
approved these changes
Sep 14, 2021
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Oct 26, 2021
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for the FSBASE and GSBASE registers on x86_64.
It also lays the groundwork for supporting additional special segment
registers on other architectures. It does this by adding a callback
LookupSegmentBasePointerthat takes anArchFnindicating whichsegment register is being read, and returns a base pointer to that
memory segment.