Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LLVM 14 #219

Merged
merged 6 commits into from
Apr 10, 2023
Merged

Support LLVM 14 #219

merged 6 commits into from
Apr 10, 2023

Conversation

RyanGlScott
Copy link
Contributor

@RyanGlScott RyanGlScott commented Apr 7, 2023

All of the changes needed to support LLVM 14 involve new metadata fields.

@langston-barrett
Copy link
Contributor

I see some btf_tag content, will this PR close #188?

@RyanGlScott
Copy link
Contributor Author

Indeed it will. (The commit message for the Support btf_tag annotations commit should ensure that this is in fact closed.)

Copy link
Contributor

@langston-barrett langston-barrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@@ -64,3 +66,5 @@ the developers' documentation for more details and a rationale:
[fuzz-workflow]: https://github.com/GaloisInc/llvm-pretty-bc-parser/blob/master/.github/workflows/llvm-quick-fuzz.yml
[llvm13]: https://github.com/GaloisInc/llvm-pretty-bc-parser/issues?q=is%3Aopen+is%3Aissue+label%3Allvm%2F13.0
[llvm14]: https://github.com/GaloisInc/llvm-pretty-bc-parser/issues?q=is%3Aopen+is%3Aissue+label%3Allvm%2F14.0
[llvm15]: https://github.com/GaloisInc/llvm-pretty-bc-parser/issues?q=is%3Aopen+is%3Aissue+label%3Allvm%2F15.0
[llvm16]: https://github.com/GaloisInc/llvm-pretty-bc-parser/issues?q=is%3Aopen+is%3Aissue+label%3Allvm%2F16.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I really like providing these links to issue tags!

@RyanGlScott RyanGlScott marked this pull request as ready for review April 10, 2023 11:11
@RyanGlScott
Copy link
Contributor Author

Successful llvm-quick-fuzz job including LLVM 14: https://github.com/GaloisInc/llvm-pretty-bc-parser/actions/runs/4656935372

@RyanGlScott RyanGlScott merged commit 59e6991 into master Apr 10, 2023
@RyanGlScott RyanGlScott deleted the llvm-14 branch April 10, 2023 11:20
RyanGlScott added a commit to GaloisInc/crucible that referenced this pull request Apr 20, 2023
This adds support for LLVM versions up to 14 by:

* Bumping the `llvm-pretty` submodule to bring in the changes from
  GaloisInc/llvm-pretty#109.
* Bumping the `llvm-pretty-bc-parser` submodule to bring in the changes from
  GaloisInc/llvm-pretty-bc-parser#219.
* Updating the test output in `crux-llvm` and `uc-crux-llvm`'s test suites
  accordingly.
RyanGlScott added a commit to GaloisInc/saw-script that referenced this pull request Apr 20, 2023
This adds support for LLVM versions up to 14 by:

* Bumping the `llvm-pretty` submodule to bring in the changes from
  GaloisInc/llvm-pretty#109.
* Bumping the `llvm-pretty-bc-parser` submodule to bring in the changes from
  GaloisInc/llvm-pretty-bc-parser#219.
* Bumping the `crucible` submodule to bring in the changes from
  GaloisInc/crucible#1083.
* Updating the surrounding documentation accordingly.
RyanGlScott added a commit to GaloisInc/saw-script that referenced this pull request May 26, 2023
This adds support for LLVM versions up to 14 by:

* Bumping the `llvm-pretty` submodule to bring in the changes from
  GaloisInc/llvm-pretty#109.
* Bumping the `llvm-pretty-bc-parser` submodule to bring in the changes from
  GaloisInc/llvm-pretty-bc-parser#219.
* Bumping the `crucible` submodule to bring in the changes from
  GaloisInc/crucible#1083.
* Updating the surrounding documentation accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants