Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling #9

Merged
merged 9 commits into from
Feb 3, 2021
Merged

Error handling #9

merged 9 commits into from
Feb 3, 2021

Conversation

brianhuffman
Copy link
Contributor

This PR reimplements many parts of the byte parser for JVM classes to avoid error and other partial functions, and to use the error-handling capabilities of the Get monad instead (see GaloisInc/saw-script#924).

However, this PR does not yet address the use of the array indexing operator (!), which is also partial.

@brianhuffman brianhuffman requested a review from atomb February 3, 2021 15:32
Copy link
Contributor

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I love to see fewer partial functions and more comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants