Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Don't run poetry update #1586

Merged
merged 1 commit into from
Nov 3, 2023
Merged

CI: Don't run poetry update #1586

merged 1 commit into from
Nov 3, 2023

Conversation

RyanGlScott
Copy link
Contributor

This causes poetry to regenerate the poetry.lock file with newer versions of dependencies, which defeats the point of checking in the lock file in the first place.

This mirrors a similar change applied to SAW's CI in GaloisInc/saw-script@67a25a8. The use of poetry update isn't actively causing problems with Cryptol's CI yet, but better to be safe than sorry.

This causes `poetry` to regenerate the `poetry.lock` file with newer versions
of dependencies, which defeats the point of checking in the lock file in the
first place.

This mirrors a similar change applied to SAW's CI in
GaloisInc/saw-script@67a25a8.
The use of `poetry update` isn't actively causing problems with Cryptol's CI
yet, but better to be safe than sorry.
@RyanGlScott RyanGlScott merged commit d602858 into master Nov 3, 2023
43 checks passed
@RyanGlScott RyanGlScott deleted the no-poetry-update branch November 3, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants