Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1584 #1585

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Fixes #1584 #1585

merged 3 commits into from
Nov 1, 2023

Conversation

yav
Copy link
Member

@yav yav commented Oct 27, 2023

Fix incorrect evaluation of list comprehensions with infinite generators. The problem happens when we have
an infinite generator, followed by a finite one. For an example, see #1584

@yav yav requested a review from RyanGlScott October 27, 2023 20:37
@yav yav temporarily deployed to github-pages October 27, 2023 20:37 — with GitHub Actions Inactive
@yav yav requested a review from qsctr October 27, 2023 20:37
qsctr
qsctr approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@qsctr qsctr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it might be good to add a test for the example in #1584 too.

src/Cryptol/Eval.hs Outdated Show resolved Hide resolved
@yav yav temporarily deployed to github-pages October 30, 2023 16:52 — with GitHub Actions Inactive
@yav yav merged commit 7295fc9 into master Nov 1, 2023
43 checks passed
@yav yav deleted the T1584 branch November 1, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

@qsctr qsctr qsctr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yav @RyanGlScott @qsctr