Build against sbv-10.2
#1550
Merged
Build against sbv-10.2
#1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
force-pushed
the
T1548-part-two
branch
from
a21f274
to
6ee853c
Compare
There are two motivations for doing so: * `sbv-10.0` and later no longer build against GHC 8.10 (see LeventErkok/sbv#655), but we want to use a new `sbv` version to come to a resolution to #1548. As such, we need a newer GHC. * `ghcup` now recommends GHC 9.2.8 for most usage, so it's time we switched anyway.
RyanGlScott
force-pushed
the
T1548-part-two
branch
from
6ee853c
to
77a52e3
Compare
|
Successful CI workflow that demonstrates that the Docker images now build after these changes: https://github.com/GaloisInc/cryptol/actions/runs/5543303142 |
kquick
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary motivation here is to have the Docker images and binary artifacts build against
sbv-10.2, which contains a fix for #1548. This requires a fair bit of CI rejigging, however, as our Docker images and binary artifacts were previously being built against GHC 8.10.7, which doesn't support buildingsbv-10.*. As such, we now adjust the CI to use GHC 9.2.8 (the version thatghcuprecommends at the time of writing) instead of GHC 8.10.7.