Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.Dockerfile: Sync Python, Poetry versions with CI #1534

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

RyanGlScott
Copy link
Contributor

This really ought to have been done at the same time as #1493/#1519, but this was overlooked due to CI-related oversights.

Without these changes, the cryptol-remote-api Docker image fails to build. (This was something I noticed when preparing the 3.0.0 release.) Once this lands, I will push these to the release-3.0.0 branch as well.

This really ought to have been done at the same time as #1493/#1519, but this
was overlooked due to CI-related oversights.
@RyanGlScott RyanGlScott requested a review from kquick June 26, 2023 16:28
@RyanGlScott RyanGlScott temporarily deployed to github-pages June 26, 2023 16:28 — with GitHub Actions Inactive
@RyanGlScott
Copy link
Contributor Author

I manually fired off a CI workflow that builds the cryptol-remote-api Docker image, and this appears to fix the issues that I was observing, judging by the fact that this has a green mark: https://github.com/GaloisInc/cryptol/actions/runs/5380114787/jobs/9762336937

@RyanGlScott RyanGlScott merged commit 5139971 into master Jun 26, 2023
43 checks passed
@RyanGlScott RyanGlScott deleted the forward-port-docker-fix-3.0.0 branch June 26, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants