cryptol-remote-api: Don't use verbose SBV settings
#1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should try to match Cryptol's default settings when invoking the remote API, but the `pcVerbose` value (`True`) didn't match the defaults. Changing this to `False` should fix #1378. There is a separate question of whether remote API users should be able to change this default, but for the time being, let's at least be consistent between Cryptol's settings and the remote API's settings.
It's not easy for me to test. I have to build from source and the process is in some automated flow. Would you be willing to merge and I will let you know afterwards? |
|
Ah, OK. In any case, I think this is a pretty low-risk change, so I'm fine with just merging it as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should try to match Cryptol's default settings when invoking the remote API, but the
pcVerbosevalue (True) didn't match the defaults. Changing this toFalseshould fix #1378. There is a separate question of whether remote API users should be able to change this default, but for the time being, let's at least be consistent between Cryptol's settings and the remote API's settings.