Use prebuilt solver binaries from what4-solvers #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 15, 2021 13:11
atomb
force-pushed
the
at-prebuilt-solvers
branch
from
0baf819
to
c537017
Compare
added 6 commits
September 15, 2021 16:07
We're using GHC 8.6.5 for tests
They’re stalling for unknown reasons, and aren’t as critical as the others. Running the Linux tests is the most critical.
kquick
reviewed
Sep 19, 2021
| case "$RUNNER_OS" in | ||
| Linux) ldd $1 || true ;; | ||
| macOS) otool -L $1 || true ;; | ||
| Windows) ldd $1 || true ;; |
There was a problem hiding this comment.
What's the intent of the || true for these? It will always allow these to succeed, so is this just for getting logging output to show which binary is running and the validity of the available shared libs?
There was a problem hiding this comment.
At least ldd (and maybe otool?) return non-zero for statically-linked executables, and some of the executables we generate are expected to be statically linked. And, ultimately, yeah, the purpose of this is to have extra log output to help with debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.